docs(store): clarify ifLet vs observe re-fire semantics - #3961
Draft
aryansk wants to merge 1 commit into
Draft
Conversation
The deprecated Store.ifLet only fires on nil/non-nil transitions
(removeDuplicates by presence), while the suggested
observe { if let store.scope } re-fires on any child state
mutation. Callers recreating views/controllers inside observe
see duplicates; gate on the optional's identity instead.
Refs pointfreeco#3871
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the deprecated
Store.ifLet(then:else:)message to call out the core semantic difference from its suggested replacementobserve { if let store.scope }:ifLet(then:else:)fires only on nil/non-nil transitions (viaremoveDuplicatesby presence).observe { if let store.scope }re-fires on any child state mutation while non-nil.Callers that recreate views/controllers inside the
observebody see duplicates (the reported UIKit bug). The new message directs authors to distinguish the optional's presence from child mutations or to gate recreation on the optional's identity.Issue
Addresses #3871 — migration from
ifLet(then:else:)toobserveduplicates work on child mutations.Validation
git diff --checkpasses