Add init accessor to DependencyEndpoint macro #362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm attempting to fix behavior that broke after #355.
cc @mbrandonw
I've added initAccessor boolean property, added snapshot tests for possible scenarios.
Still in draft because it would have a possible bug that were removed from documentation in release 1.9.2:
Old bug reproduced
I tried to add tests on issuereporting call that would be expected in this scenario.
I'm open to ideas on how we can fix this.
If we can't, probably asking everyone to provide own init is better than have this bug still here.
The library works fine with all old cases, and I just found one specific case that would break it, but it can be avoided with custom init.