Initialize endpoints through storage instead of computed property - #470
Merged
Conversation
mbrandonw
force-pushed
the
init-closures-last
branch
from
August 24, 2026 16:25
1e23254 to
6ce7450
Compare
stephencelis
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now something like this does not compile:
The reason is that
@DependencyEndpointis applied toendpointand notidentifier, and that macro turns the stored property into a stored+computed property combo. The initializer sets only the computed property, not the stored. We used to work around this with an init accessor, but that caused other problems (#355). So instead we can just set the underscored stored property in the initializer.