Conversation
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 26.2.0 to 26.4.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.4.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…dev/types/node-26.4.0 build(deps-dev): bump @types/node from 26.2.0 to 26.4.0
Bumps [tsx](https://github.com/privatenumber/tsx) from 4.23.12 to 4.23.13. - [Release notes](https://github.com/privatenumber/tsx/releases) - [Changelog](https://github.com/privatenumber/tsx/blob/master/release.config.cjs) - [Commits](privatenumber/tsx@v4.23.12...v4.23.13) --- updated-dependencies: - dependency-name: tsx dependency-version: 4.23.13 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…dev/tsx-4.23.13 build(deps-dev): bump tsx from 4.23.12 to 4.23.13
There was a problem hiding this comment.
🟢 Approval recommended
The removed dependency is not imported anywhere (only referenced in a comment), the fuzz crate is a confirmed workspace member, and the workspace override aligns with the resolved lockfile versions.
Pull request overview
This PR reduces the dependency/security surface by removing an unused wallet-kit dependency and tightening workspace-level pnpm policies, with the goal of clearing the Dependabot and pnpm audit vulnerability backlog.
Changes:
- Removed
@creit.tech/stellar-wallets-kitfromclient-sdkandfarms-sdkmanifests and unified@stellar/stellar-sdkto^14.6.1across packages touched. - Deleted
tests/fuzz/Cargo.lock(the fuzz crate is a workspace member, so the root lockfile governs resolution). - Added a workspace override to keep
postcsson a patched8.5.xline and pruned pnpm policy exceptions that no longer apply.
File summaries
| File | Description |
|---|---|
| tests/fuzz/Cargo.lock | Removes the nested lockfile for the fuzz workspace member. |
| pnpm-workspace.yaml | Adds a postcss override and prunes trust/build policy exceptions. |
| packages/farms-sdk/package.json | Drops unused wallet-kit dependency; bumps @stellar/stellar-sdk range; formatting cleanup. |
| packages/client-sdk/package.json | Drops unused wallet-kit dependency; bumps @stellar/stellar-sdk range; formatting cleanup. |
| packages/cli/package.json | Unifies @stellar/stellar-sdk version and bumps tsx patch. |
| package.json | Updates dev tooling versions and unifies root @stellar/stellar-sdk range. |
Review details
- Files reviewed: 5/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the Dependabot backlog. Alerts are computed on the default branch, so they stay
open until this reaches
main.Result
pnpm audit: 66 → 0Dependabot alerts: 76 → 2 (both remaining are Rust, see below).
What changed
@creit.tech/stellar-wallets-kitremoved fromclient-sdkandfarms-sdk.It was declared in both manifests but imported nowhere.
client-sdk/src/services/swap.tssays why:
The SDK already takes a structural
SigningKitinterface. The manifest entries wereleftovers. Dropping them removed 520 transitive packages (
pnpm-lock.yaml: 1840 → 870entries) and closed 61 alerts, including
ellipticGHSA-848j-6mx2-7j84, for which nopatched version exists — removing the source was the only available fix.
This supersedes #201, which bumped the same dependency; it is now closed.
tests/fuzz/Cargo.lockdeleted.tests/fuzzis a member of the root workspace(
members = [..., "tests/fuzz"]), socargo metadata --manifest-path tests/fuzz/Cargo.tomlreports
workspace_root= repo root — the nested lockfile was never read. It had not beentouched since June 2025 and still pinned soroban-sdk 22.0.8 against a manifest requiring
^25.0.0. 10 alerts.pnpm-workspace.yaml— addedoverrides.postcss: ^8.5.23for the last dev-only chain(
@antfu/eslint-config → @vue/compiler-sfc → postcss → nanoid); pruned 11allowBuildsand 4
trustPolicyExcludeentries whose packages no longer resolve.Side effect:
@stellar/stellar-sdkunified from three ranges (^14.4.0,^14.1.1,^14.1.1) to^14.6.1.Verified
pnpm audit— 0 vulnerabilitiespnpm install --frozen-lockfile— cleancargo nextest run --workspace --lib— 320 passed, 1 skippedcargo check -p lending-fuzz --all-targets— builds without its lockfiletsc --noEmit— clean inclient-sdk(the package that held the kit) andcliNot fixed here
Two Rust alerts remain and cannot move inside
soroban-sdk ^25:soroban-env-common 25.2.2declares
stellar-xdr =25.0.0exactly.stellar-xdrGHSA-x57h-xx53-v53w (medium)soroban-env-hostGHSA-pm4j-7r4q-ccg8 (low)Both need soroban-sdk ≥ 26, which rebuilds every wasm and implies an on-chain redeploy.
That is blocked upstream regardless:
sep-40-oracle 1.4.0requiressoroban-sdk ^25.0.1and
soroban-fixed-point-math 1.5.0requires^25.script3/soroban-fixed-point-math#11("Upgrade to Soroban SDK 27") is open;
script3/sep-40-oraclehas no p27 branch yet.Worth noting separately: mainnet is on protocol 27 while we compile against SDK 25.
Unrelated pre-existing issues spotted
vitestis not installed and never was (0 entries in the lockfile at any commit), sopnpm testhas always failed. One test file exists:client-sdk/src/utils/pool-status.test.ts.packages/sdk/*fail declaration emit under TypeScript 6 withTS5011(rootDirmustbe set explicitly), so consumers of the
link:bindings cannot typecheck from a clean tree.