Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check dtype to avoid panic with mixed types in min/max_horizontal #21857

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kdn36
Copy link
Contributor

@kdn36 kdn36 commented Mar 19, 2025

Fixes #21835

(A prior attempt PR #21845 was closed by myself and can be ignored - I accidentally messed something up in git).

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 19, 2025
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (5e24b89) to head (d78bcb4).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21857      +/-   ##
==========================================
- Coverage   80.92%   80.84%   -0.08%     
==========================================
  Files        1623     1628       +5     
  Lines      234177   235121     +944     
  Branches     2693     2693              
==========================================
+ Hits       189513   190090     +577     
- Misses      44032    44398     +366     
- Partials      632      633       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ritchie46
Copy link
Member

Thanks, can you add a test in python?

@kdn36
Copy link
Contributor Author

kdn36 commented Mar 27, 2025

I think this is ready to be merged. The CI failures seem unrelated, kindly review.

The only detail that is not straightforward (for me) is the use of 'i64' literal in the expected error message, vs eg 'i32'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

min / max_horizontal PanicException for mixed types
2 participants