Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use Optional for InitVar type hint #21943

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ruoyeruolan
Copy link

Update type hint from InitVar[list[str]] to InitVar[Optional[list[str]]] to explicitly allow None during initialization, matching the default value and improving type checker accuracy

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Mar 27, 2025
@ruoyeruolan ruoyeruolan reopened this Mar 27, 2025
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.86%. Comparing base (cdd8032) to head (d54cac4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21943   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files        1631     1631           
  Lines      235490   235490           
  Branches     2693     2693           
=======================================
+ Hits       190438   190440    +2     
+ Misses      44419    44416    -3     
- Partials      633      634    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant