feat: Improved expression autocomplete for IPython
, Jupyter
, and Marimo
#22221
+18
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16933 (and #20496).
Ref: marimo-team/marimo#3302
Ref: davidhalter/jedi#2057
Thanks to some very helpful analysis by @krassowski, the exact mechanism that causes Jedi/Parso-based autocomplete (eg: as found in
IPython
,Jupyter
, andMarimo
) to fail for Polars' namespaced expression methods was identified.With the new info in mind, I was able to craft a small workaround to solve it on our side.
"Our long national autocomplete nightmare is over..."1 ✌️😎
(Note: everything was already fine in the major editors such as PyCharm and VSCode, as well as anything using pylance on the backend for LSP/autocomplete).
Before
IPython:
Marimo:
After
IPython:
Marimo:
Footnotes
Ref: the inauguration of Gerald Ford, remarks ↩