-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rust): Fix str.to_integer
panics for certain inputs
#22243
Open
math-hiyoko
wants to merge
3
commits into
pola-rs:main
Choose a base branch
from
math-hiyoko:fix/#22242
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22243 +/- ##
==========================================
- Coverage 80.78% 80.77% -0.01%
==========================================
Files 1639 1639
Lines 235548 235549 +1
Branches 2714 2714
==========================================
- Hits 190278 190270 -8
- Misses 44630 44638 +8
- Partials 640 641 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
str.to_integer
panics for certain inputs
Can someone review this? |
I’ve made some minor adjustments; everything is ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue #22242 where calling str.to_integer() with strict=True unexpectedly panics for certain inputs.
The problem occurs because the values s and base at line 118 do not always correspond correctly, which leads to the bug. This PR modifies how some_failures is retrieved in original order so that s and base are properly paired, preventing the panic.
polars/crates/polars-ops/src/chunked_array/strings/namespace.rs
Lines 95 to 124 in 69ad1ba
close #22242