Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle floating point precision issue at histogram breakpoints #22244

Closed
wants to merge 1 commit into from
Closed

fix: Handle floating point precision issue at histogram breakpoints #22244

wants to merge 1 commit into from

Conversation

anath2
Copy link
Contributor

@anath2 anath2 commented Apr 12, 2025

Addresses precision issue highlighted in #22234 by checking the value is greater than the breakpoint boundary

@anath2 anath2 changed the title fix(rust): Check if the value is greater than hist breakpoint if value falls on the breakpoint. fix: Check if the value is greater than hist breakpoint if value falls on the breakpoint. Apr 12, 2025
@anath2 anath2 changed the title fix: Check if the value is greater than hist breakpoint if value falls on the breakpoint. fix: Handle floating point precision issue at histogram breakpoints Apr 12, 2025
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Apr 12, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 12, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.78%. Comparing base (69ad1ba) to head (99c1237).

Files with missing lines Patch % Lines
crates/polars-ops/src/chunked_array/hist.rs 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #22244   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files        1639     1639           
  Lines      235548   235551    +3     
  Branches     2714     2714           
=======================================
+ Hits       190278   190297   +19     
+ Misses      44630    44613   -17     
- Partials      640      641    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anath2
Copy link
Contributor Author

anath2 commented Apr 12, 2025

Closing this PR as the fix is addressed in #22245

@anath2 anath2 closed this Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 will be requested when the pull request is marked ready for review ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp will be requested when the pull request is marked ready for review orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters will be requested when the pull request is marked ready for review c-peters is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anath2