perf: Optimize ArrayFromIter implementations for ObjectArray #25712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-dtype-object
AndreaBozzo
force-pushed
the
perf/optimize-objectarray-arrayfromiter
branch
from
cb9330a to
30d8dbe
Compare
- Add direct implementations instead of delegating through `Result` wrappers - Add `TrustedLen` variants (`arr_from_iter_trusted`, `try_arr_from_iter_trusted`) for both `&T` and `Option<&T>` to enable exact pre-allocation - Remove unnecessary indirection and `.unwrap()` calls - Remove TODO comment as the implementations are now efficient
AndreaBozzo
force-pushed
the
perf/optimize-objectarray-arrayfromiter
branch
from
30d8dbe to
a62278e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25712 +/- ##
==========================================
- Coverage 80.57% 79.66% -0.92%
==========================================
Files 1764 1764
Lines 242704 242823 +119
Branches 3042 3044 +2
==========================================
- Hits 195561 193445 -2116
- Misses 46361 48596 +2235
Partials 782 782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AndreaBozzo
requested review from
c-peters,
orlp and
ritchie46
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a TODO in the code asking for more efficient implementations , this PR tackles that by adding TrustedLen variants and removing the Result wrapper workarounds.
I did not plan on adding tests on this, but i can improve the coverage if maintainers want to
ResultwrappersTrustedLenvariants for exact pre-allocation.unwrap()callsTest plan
cargo build -p polars-core --features objectcargo test -p polars-core --features object