fix: Sanitize error messages to prevent terminal control character injection #25781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SanitizeErrorDetailutility to sanitize strings for error messagesProblem
When accidentally reading binary files (like parquet) with
pl.read_csv(), the error messages could contain terminal control characters that interfere with terminal output (e.g., escape sequences like\033cthat clear the screen or reset the terminal).Solution
This PR adds a
SanitizeErrorDetailutility that:The CSV parser now uses this utility when displaying unparsable field values in error messages.
Test plan
sanitize_for_error_displayfunctionSanitizeErrorDetailstructFixes #16106