feat(python): Allow passing Callable[[str], bool] to sheet_name parameter of polars.read_excel
#25882
+17
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameter of `polars.read_excel` The `sheet_name` parameter now supports predicate function (`Callable[[str], bool]`) for flexible sheet selection. This is useful when sheet names are generated dynamically (e.g. by date) or when the number of sheets varies between files. This change is fully backward compatible.
misha-artyugin
requested review from
MarcoGorelli,
alexander-beedie,
c-peters,
reswqa and
ritchie46
as code owners
github-actions
bot
added
A-io-spreadsheet
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25882 +/- ##
==========================================
- Coverage 80.62% 79.83% -0.80%
==========================================
Files 1765 1763 -2
Lines 243158 242869 -289
Branches 3044 3044
==========================================
- Hits 196055 193885 -2170
- Misses 46321 48203 +1882
+ Partials 782 781 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexander-beedie
requested changes
Dec 28, 2025
Collaborator
alexander-beedie
left a comment
alexander-beedie
left a comment
There was a problem hiding this comment.
Lint needs to pass (appears to be failing in the commit tests).
Otherwise this would be fine by me, thanks 👍
hamdanal
reviewed
Dec 29, 2025
| msg = f"cannot specify both `sheet_name` ({sheet_name!r}) and `sheet_id` ({sheet_id!r})" | ||
| raise ValueError(msg) | ||
|
|
||
| if isinstance(sheet_name, Callable): # rewrite sheet_name to a list of names |
Contributor
There was a problem hiding this comment.
Shouldn’t this be
Suggested change
| if isinstance(sheet_name, Callable): # rewrite sheet_name to a list of names | |
| if callable(sheet_name): # rewrite sheet_name to a list of names |
Author
There was a problem hiding this comment.
Hi,
I’ve addressed the requested changes.
Thanks and Happy New Year!
Author
|
All requested changes have been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for passing a predicate function (
Callable[[str], bool]) to thesheet_nameparameter ofpl.read_excel, allowing flexible sheet selection.Why?
In practice, Excel files often contain sheets with dynamically generated names (e.g. dates) or a variable number of sheets. A predicate-based parameter allows users to select sheets programmatically without relying on
exact string matches.
Changes
sheet_nameto accept a callable predicateBackward compatibility
This change is fully backward compatible. Existing usages of
sheet_name(string, list of strings, etc.) are unaffected.Tests