-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: Add nulls support for rolling_mean_by #25917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add nulls support for rolling_mean_by #25917
Conversation
d84a6a4 to
96d51c8
Compare
CI failure seems unrelated, didn't find the run again button. |
| ))); | ||
| } | ||
| // start with a dummy index, will be overwritten on first iteration. | ||
| // SAFETY: FIXME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixme? Safety here is trivial as 0..0 is in-bounds for any array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to rework Ag::new to just check to make it safe though, it's not called often.
|
I fixed the issue that causes the tests to fail, update your branch an rerun the github actions and the tests should pass |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25917 +/- ##
==========================================
- Coverage 80.51% 80.50% -0.02%
==========================================
Files 1771 1772 +1
Lines 243271 243422 +151
Branches 3037 3037
==========================================
+ Hits 195875 195955 +80
- Misses 46614 46685 +71
Partials 782 782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes: #25848