Skip to content

demo - force group positions to match AggState#26433

Draft
nameexhaustion wants to merge 1 commit intomainfrom
nxs/groups
Draft

demo - force group positions to match AggState#26433
nameexhaustion wants to merge 1 commit intomainfrom
nxs/groups

Conversation

@nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Feb 5, 2026

This PR forces GroupPositions to match AggState within AggregationContext.

In doing so, multiple queries will fail - e.g.

>>> df = pl.DataFrame({"a": [1, 1, 2, 2, 3], "b": [1, 2, 1, 2, 1]})
>>> df.group_by(pl.lit(1)).agg(a=pl.col("a").first().filter(pl.col("b") >= 0))
  • Expected results
shape: (1, 2)
┌─────────┬─────────────┐
│ literal ┆ a           │
│ ---     ┆ ---         │
│ i32     ┆ list[i64]   │
╞═════════╪═════════════╡
│ 1       ┆ [1, 1, … 1] │
└─────────┴─────────────┘
  • Results from this PR
shape: (1, 2)
┌─────────┬───────────┐
│ literal ┆ a         │
│ ---     ┆ ---       │
│ i32     ┆ list[i64] │
╞═════════╪═══════════╡
│ 1       ┆ [1]       │
└─────────┴───────────┘

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

The uncompressed lib size after this PR is 52.4220 MB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments