fix(rust): Prevent struct.with_fields from broadcasting unit lengths that are non-scalar#26608
Open
Kevin-Patyk wants to merge 9 commits intopola-rs:mainfrom
Open
fix(rust): Prevent struct.with_fields from broadcasting unit lengths that are non-scalar#26608Kevin-Patyk wants to merge 9 commits intopola-rs:mainfrom
struct.with_fields from broadcasting unit lengths that are non-scalar#26608Kevin-Patyk wants to merge 9 commits intopola-rs:mainfrom
Conversation
Kevin-Patyk
requested review from
MarcoGorelli,
alexander-beedie,
c-peters,
orlp and
ritchie46
as code owners
github-actions
bot
added
A-dtype-struct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #26022.
The logic already existed for throwing an error in this exact situation, but for
.with_columns()in crates/polars-mem-engine/src/executors/stack.rs, so the provided solution is nothing novel. I just had to find the right placement.Claude Sonnet 4.5 was to help me navigate the codebase and to translate the error over to a new context.