fix: Rounding behaviour for f32 values with "HalfAwayFromZero" mode#26624
Open
alexander-beedie wants to merge 1 commit intopola-rs:mainfrom
Open
fix: Rounding behaviour for f32 values with "HalfAwayFromZero" mode#26624alexander-beedie wants to merge 1 commit intopola-rs:mainfrom
f32 values with "HalfAwayFromZero" mode#26624alexander-beedie wants to merge 1 commit intopola-rs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26624 +/- ##
==========================================
+ Coverage 81.38% 81.39% +0.01%
==========================================
Files 1794 1794
Lines 245003 245002 -1
Branches 3080 3080
==========================================
+ Hits 199393 199428 +35
+ Misses 44824 44788 -36
Partials 786 786 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
f32path with "RoundMode::HalfAwayFromZero" was usinground_ties_eveninstead ofround. Fixed, and added explicit test coverage for f16/f32/f64 values that triggers the tiebreaks that found the bug 👍