Draft
Conversation
Author
catbrower
suggested changes
Apr 14, 2025
catbrower
left a comment
There was a problem hiding this comment.
what is mtalib? Apologies but this entire PR feels like a typo. Requesting changes to clarify.
| ``` | ||
| """ | ||
| import talib | ||
| from talib import abstract |
There was a problem hiding this comment.
why are we importing talib here? They should already be available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

For example, I have 1 minute scale tick data, and I'd like add 5 minute/ 15 minute feature upon .
I wrote a function
This generate 5 minute SMA features for each 1 minute tick .
you can think
arr = np.arange(1000).astype(float)as a stock close price at minute level .It is a 1000 time tick collection.
On every tick , I need calculate
sma5ontalib.SMA(arr, 5))apply_over(lambda a: talib.SMA(a, 5) , arr, 5))apply_over(lambda a: talib.SMA(a, 5) , arr, 15))For example:
A series
...,500, 501, 502, 503, 504 , 505,....At 505,
Using
pandas resmple(freq='5min').first()would make gaps , shrinkarrlength from1000to200. You need do it 5 times with each shift [0,1,2,3,4] and applySMAto make sure every tick have 5 minute feature, , like what I do inapply_overBecause I really like vectorbt, so share this idea here.