Skip to content

Comments

feat: support polaris config center#91

Open
fuyuwei01 wants to merge 6 commits intopolarismesh:dubbo-2.7.xfrom
fuyuwei01:dubbo-2.7.x-config
Open

feat: support polaris config center#91
fuyuwei01 wants to merge 6 commits intopolarismesh:dubbo-2.7.xfrom
fuyuwei01:dubbo-2.7.x-config

Conversation

@fuyuwei01
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 41.90476% with 122 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.01%. Comparing base (6dd77bc) to head (bfd17b1).

Files with missing lines Patch % Lines
...ncent/polaris/common/registry/PolarisOperator.java 0.00% 81 Missing ⚠️
...cent/polaris/common/registry/PolarisOperators.java 0.00% 22 Missing ⚠️
...tencent/polaris/common/registry/PolarisConfig.java 0.00% 18 Missing ⚠️
...laris/common/registry/PolarisOperatorDelegate.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             dubbo-2.7.x      #91       +/-   ##
==================================================
+ Coverage           3.89%   16.01%   +12.12%     
- Complexity             5       24       +19     
==================================================
  Files                 13       15        +2     
  Lines                488      668      +180     
  Branches              78       89       +11     
==================================================
+ Hits                  19      107       +88     
- Misses               464      556       +92     
  Partials               5        5               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


private PolarisOperators() {
polarisOperatorMap = new ConcurrentHashMap<>();
polarisOperatorMap.put(OperatorType.GOVERNANCE, new ConcurrentHashMap<>());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用map的原因是?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和3.2的实现对齐

@Override
public boolean publishConfig(String key, String group, String content) throws UnsupportedOperationException {
try {
ConfigPublishRequest request = new ConfigPublishRequest();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

研究下使用场景

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

仅dubbo2.7在使用应用级服务发现时会用到,但是当前我们不支持应用级服务发现,官方文档中也不建议用户在dubbo2.7中使用应用级服务发现

}

@Override
public Object getInternalProperty(String key) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dubbo2.7中只有几个属性支持在外部配置中单独存放,其他大部分的常用配置项在外部配置中心只能从dubbo.properties中读取。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants