feat: support load nearby routes from cache files #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/flow/base_flow.go
Outdated
| } | ||
|
|
||
| // 如果至少有一个规则已初始化，则标记为已启用 | ||
| if routeRule.IsInitialized() || nearbyRouteRule.IsInitialized() { |
Member
There was a problem hiding this comment.
规则路由和就近路由共用trigger.EnableDstRoute吗？
SkyeBeFreeman
suggested changes
Dec 16, 2025
| // invalidRegexes = false | ||
| for _, source := range sources { | ||
| for i, source := range sources { | ||
| log.GetBaseLogger().Debugf("[RuleBasedRouter] matchSource: checking source[%d], ns=%s, svc=%s, metadataCount=%d, metadata=%v", |
Member
There was a problem hiding this comment.
建议使用if log.GetBaseLogger().IsLevelEnabled(log.DebugLog)判断是否开启debug日志，因为所有的请求都处理source.Metadata的序列化，可能会有性能损耗。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide issue(s) of this PR:
feat: support load nearby routes from cache files
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.