Skip to content

Commit 4f783c4

Browse files
fix:fix log config not working bug in higher version Logback. (#272)
1 parent c0fd23f commit 4f783c4

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

polaris-common/polaris-logging/src/main/java/com/tencent/polaris/logging/logback/LogbackPolarisLogging.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import ch.qos.logback.classic.LoggerContext;
2121
import ch.qos.logback.classic.util.ContextInitializer;
2222
import com.tencent.polaris.logging.AbstractPolarisLogging;
23+
import org.slf4j.LoggerFactory;
2324
import org.slf4j.impl.StaticLoggerBinder;
2425

2526
public class LogbackPolarisLogging extends AbstractPolarisLogging {
@@ -34,7 +35,7 @@ public void loadConfiguration() {
3435
}
3536

3637
try {
37-
LoggerContext loggerContext = (LoggerContext) StaticLoggerBinder.getSingleton().getLoggerFactory();
38+
LoggerContext loggerContext = (LoggerContext) LoggerFactory.getILoggerFactory();
3839
new ContextInitializer(loggerContext).configureByResource(getResourceUrl(location));
3940
} catch (Exception e) {
4041
throw new IllegalStateException("could not initialize logback logging from " + location, e);

pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464

6565
<properties>
6666
<!-- Project revision -->
67-
<revision>1.10.2</revision>
67+
<revision>1.10.3</revision>
6868

6969
<timestamp>${maven.build.timestamp}</timestamp>
7070
<skip.maven.deploy>false</skip.maven.deploy>

0 commit comments

Comments
 (0)