Fix npm test on Node 24+ - #22
Conversation
|
Same comment as #21 -- please write prose intended for humans (commit messages, PR messages, code comments) by hand. |
Fixes an issue where the test script passed --experimental-async-context-frame unconditionally, which is required for Node.js 22 and 23, but since Node.js 24 doesn't support it, it caused npm test to fail on it.
0da50ea to
e119782
Compare
@umanwizard happy to oblige. Apologies, and I will keep myself to it going forward. I rewrote both the description of this PR and the commit message, and will do so for the other two currently open PRs as well. (Fair warning: I do use em-dashes in my own writing style.) |
|
Thanks! Sorry for being difficult, I just find the Claude-generated PR messages hard to read, because they are too verbose and contain a lot of unnecessary detail (and you can never be sure how much is the author's knowledge/opinion, vs. how much is Claude's). The new PR message is much simpler! |
3 participants
Fixes an issue where the test script passed
--experimental-async-context-frameunconditionally, which is required for Node.js 22 and 23, but since Node.js 24 doesn't support it, it causednpm testto fail on it: