-
Notifications
You must be signed in to change notification settings - Fork 8
Added example with Nuxt #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@ronitize is attempting to deploy a commit to the polar-sh Team on Vercel. A member of the Team first needs to authorize it. |
@rishi-raj-jain can I get a review on this . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please use the scope setup as in https://github.com/polarsource/examples/blob/main/with-astro-cloudflare-workers/scope.ts and https://github.com/polarsource/examples/blob/main/with-astro-cloudflare-workers/package.json#L8?
This is amazing btw! Loved your submission! |
with-nuxt/app/app.vue
Outdated
<script setup lang="ts"> | ||
// You can leave this script block empty. | ||
// It's a good place for app-wide logic if you need it later. | ||
</script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this required? can this be removed?
I've updated the bounty to be $150 for the efforts. |
@rishi-raj-jain if the examples are for beginners wouldn't this scope.ts setup with the package.json script would be complex for them ? There is no harm for them to have an extra env variable |
Nope, since beginners have to learn this way of using Polar for managing the ideal environments. A script like this is a no brainer for someone who knows how to code their Astro/Nuxt project :) |
Should've clarified in my original message, the envs now should be only:
|
@rishi-raj-jain can I get a review on this |
@rishi-raj-jain can we get this merged by EOD? |
@ronitize Unfortunately not, I'll be taking a look at the weekend. |
@rishi-raj-jain Should we finish this today? |
@rishi-raj-jain any particular reason of delaying this ? |
@ronitize no reason in particular, just that I am buried under the number of tickets people are opening with Polar support :) |
@rishi-raj-jain The issue which the pr solves is now like a month old , I get you are over burdened with polar support . Check this url for an easier diff since your last review . |
Thank you for showing empathy with my situation. Don't worry, I'll take a look at it soon. |
fix #6
with-nuxt
main /export-all-customers-to-csv
neondatabase/examples@main/with-nestjs
Deployed URL - https://polar-nuxt.vercel.app
Video Recording :
output.mp4