Skip to content

Conversation

@joeljkrb
Copy link
Collaborator

  • Added German localisation files
  • Fixed missing translation keys
  • Added German to language selection dropdown
  • Ordered language options alphabetically by name

Closes #2657

Thanks to @Daredevil-3x7 for providing the translations

joeljkrb and others added 2 commits April 16, 2025 13:43
- Added German localisation files
- Fixed missing translation keys
- Added German to language selection dropdown
- Ordered language options alphabetically by name

Closes #2657

Thanks to @Daredevil-3x7 for providing the translations
@rossbulat
Copy link
Collaborator

Thanks @Daredevil-3x7 for the support!

I think it's worth holding off merging this until #2748 is merged - it is a revamp of the help material and locales will change. Let's revisit this once that task is complete.

@rossbulat rossbulat requested a review from Copilot June 7, 2025 03:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds German (DE) translations and integrates German into the app’s locale configuration, ensuring the language dropdown remains alphabetically ordered.

  • New German JSON resource files for tips, pages, modals, and app texts
  • Updated index.ts to import and register the German locale
  • Sorted locale entries alphabetically by language label

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/locales/src/resources/de/tips.json Added German translations for tips
packages/locales/src/resources/de/pages.json Added German translations for page labels and messages
packages/locales/src/resources/de/modals.json Added German translations for modal dialogs
packages/locales/src/resources/de/app.json Added German translations for core app strings
packages/locales/src/index.ts Imported de locale and added German entry in locales

"averageRewardRate": "Durchschnittliche Belohnungsrate",
"back": "Zurück",
"balance": "Guthaben",
"beenClaimed": "an Belohnungen wurden beansprucht.",
Copy link

Copilot AI Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The German string has an extraneous "an" at the start. It would read more naturally as "Belohnungen wurden beansprucht."

Suggested change
"beenClaimed": "an Belohnungen wurden beansprucht.",
"beenClaimed": "Belohnungen wurden beansprucht.",

Copilot uses AI. Check for mistakes.
"Erweiterungen verbinden",
"Verbinden Sie Ihre Konten, um Polkadot Cloud Staking zu nutzen.",
[
"Verbinden Sie Ihre Konten, um Polkadot Cloud Staking zu nutzen.",
Copy link

Copilot AI Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This detailed tip duplicates the short description above. Consider removing or varying this entry to avoid redundancy.

Suggested change
"Verbinden Sie Ihre Konten, um Polkadot Cloud Staking zu nutzen.",
"Verbinden Sie Ihre Konten, um Polkadot Cloud Staking zu nutzen. Dies ermöglicht Ihnen, Transaktionen zu signieren und Belohnungen zu erhalten.",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DE-Translation

3 participants