-
Notifications
You must be signed in to change notification settings - Fork 187
feat(locales): Add German (DE) translation #2658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Added German localisation files - Fixed missing translation keys - Added German to language selection dropdown - Ordered language options alphabetically by name Closes #2657 Thanks to @Daredevil-3x7 for providing the translations
|
Thanks @Daredevil-3x7 for the support! I think it's worth holding off merging this until #2748 is merged - it is a revamp of the help material and locales will change. Let's revisit this once that task is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds German (DE) translations and integrates German into the app’s locale configuration, ensuring the language dropdown remains alphabetically ordered.
- New German JSON resource files for tips, pages, modals, and app texts
- Updated
index.tsto import and register the German locale - Sorted locale entries alphabetically by language label
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/locales/src/resources/de/tips.json | Added German translations for tips |
| packages/locales/src/resources/de/pages.json | Added German translations for page labels and messages |
| packages/locales/src/resources/de/modals.json | Added German translations for modal dialogs |
| packages/locales/src/resources/de/app.json | Added German translations for core app strings |
| packages/locales/src/index.ts | Imported de locale and added German entry in locales |
| "averageRewardRate": "Durchschnittliche Belohnungsrate", | ||
| "back": "Zurück", | ||
| "balance": "Guthaben", | ||
| "beenClaimed": "an Belohnungen wurden beansprucht.", |
Copilot
AI
Jun 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The German string has an extraneous "an" at the start. It would read more naturally as "Belohnungen wurden beansprucht."
| "beenClaimed": "an Belohnungen wurden beansprucht.", | |
| "beenClaimed": "Belohnungen wurden beansprucht.", |
| "Erweiterungen verbinden", | ||
| "Verbinden Sie Ihre Konten, um Polkadot Cloud Staking zu nutzen.", | ||
| [ | ||
| "Verbinden Sie Ihre Konten, um Polkadot Cloud Staking zu nutzen.", |
Copilot
AI
Jun 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This detailed tip duplicates the short description above. Consider removing or varying this entry to avoid redundancy.
| "Verbinden Sie Ihre Konten, um Polkadot Cloud Staking zu nutzen.", | |
| "Verbinden Sie Ihre Konten, um Polkadot Cloud Staking zu nutzen. Dies ermöglicht Ihnen, Transaktionen zu signieren und Belohnungen zu erhalten.", |
Closes #2657
Thanks to @Daredevil-3x7 for providing the translations