feat(locales): add English (UK) localisation #2674
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added British English language option to enhance user experience for UK users. Changes include: - Created British English (enGB) translation files - Updated language selection UI to display English (US) and English (UK) options - Ensured proper spacing and responsive layout in language selector - Set up automatic detection for en-GB browser settings This improves the dashboard's accessibility for British users while maintaining the existing US English localisation.
rossbulat
reviewed
Apr 30, 2025
Collaborator
There was a problem hiding this comment.
Instead of duplicating a locale folder specifically for GB, I wonder if there is a way we can just amend the affected locale keys in question by:
- Providing a
-gbsuffix in theenlocale files only. - Add a mapping of
locales -> suffixes, and add checks to thevalidatescript to prevent missing key errors - Where we expect these localised keys to be used (for any language, not just
en), call a helper function that either takes the expected prefixed key, or returns the fallback.
withSuffix('key') => key | keyWithSuffix
Given:
const suffixes: Record<string, Record<string, string>> = {
en: {
'en-GB: 'gb' // within "en" locale, the "en-GB" language is supported with the "gb" suffix
}
}
And given en locale and en-GB language is active, withSuffix:
- Gets the currently active locale key
en, and the active languageen-GB - Checks if there is a suffix defined via the
suffixesmapping - Checks if the suffixed key exists, and returns it if it does, otherwise returns unsuffixed key
We then just deal with the affected keys without as much duplication.
Added a suffix-based approach to support language variants like British English (en-GB) without duplicating entire locale files. This approach only requires defining the specific keys that differ between variants. Key changes: - Created suffix mappings and withSuffix helper to dynamically select locale variants - Updated language detection to work with browser variants - Added UI support for selecting language variants - Modified validation scripts to handle suffixed keys - Added British English suffixed keys to demonstrate the approach - Created documentation explaining the suffix system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added British English language option to enhance user experience for UK users.
Changes include:
This improves the dashboard's accessibility for British users while maintaining the existing US English localisation.