feat(refactor): Remove OtherAccounts context, simplify account import logic
#3170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbulat
changed the title
OtherAccounts contextOtherAccounts context, simplify account import logic
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase by removing the OtherAccounts context, consolidating account management logic into existing contexts (ImportedAccounts and ExternalAccounts). The changes eliminate code duplication and simplify the account management architecture.
Key Changes:
- Removed the
OtherAccountscontext entirely (types and implementation) - Migrated account initialization logic to
ImportedAccountscontext - Enhanced
ExternalAccountscontext with getter method and state subscription - Updated all components to use
ImportedAccountsand direct hardware account hooks instead ofOtherAccounts
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/app/src/modals/ImportAccounts/WalletConnect.tsx | Replaced OtherAccounts usage with direct useHardwareAccounts hook calls |
| packages/app/src/modals/ImportAccounts/Vault.tsx | Removed OtherAccounts dependencies, simplified QR reader callback |
| packages/app/src/modals/ImportAccounts/Ledger.tsx | Eliminated OtherAccounts references, using only hardware account hooks |
| packages/app/src/modals/ExternalAccounts/ReadOnly/index.tsx | Removed duplicate forgetExternalAccounts call |
| packages/app/src/modals/ExternalAccounts/ReadOnly/Add.tsx | Removed redundant account management after external account addition |
| packages/app/src/hooks/useAccountFromUrl/index.tsx | Changed to use accountsInitialised from ImportedAccounts |
| packages/app/src/contexts/Proxies/index.tsx | Simplified proxy account addition by removing duplicate tracking |
| packages/app/src/contexts/Connect/OtherAccounts/types.ts | Deleted the entire types file for removed context |
| packages/app/src/contexts/Connect/OtherAccounts/index.tsx | Deleted the entire context implementation |
| packages/app/src/contexts/Connect/ImportedAccounts/types.ts | Added accountsInitialised to interface |
| packages/app/src/contexts/Connect/ImportedAccounts/index.tsx | Consolidated account aggregation and initialization logic from OtherAccounts |
| packages/app/src/contexts/Connect/ExternalAccounts/types.ts | Added getExternalAccounts method to interface |
| packages/app/src/contexts/Connect/ExternalAccounts/index.tsx | Added state management and subscription for external accounts |
| packages/app/src/Providers.tsx | Removed OtherAccountsProvider from provider chain |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
github-project-automation
bot
moved this from ✂️ In progress
to ✅ Done
in Staking Dashboard 2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the codebase by removing the
OtherAccountscontext, consolidating account management logic into existing contexts (ImportedAccountsandExternalAccounts). The changes eliminate code duplication and simplify the account management architecture.Key Changes:
OtherAccountscontext entirely (types and implementation)ImportedAccountscontextExternalAccountscontext with getter method and state subscriptionImportedAccountsand direct hardware account hooks instead ofOtherAccounts