feat(refactor): @apollo/client v3 - v4 migration
#3171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the codebase from Apollo Client v3 to v4, introducing significant changes to the GraphQL client implementation and query patterns.
Key Changes
- Upgraded
@apollo/clientfrom v3.13.9 to v4.0.11 with new peer dependency onrxjsv7.8.2 - Refactored type system with new
QueryReturn<T>type that guarantees non-null data through default values - Updated all query hooks to use type parameters and return default values instead of null/undefined
- Changed Apollo Client initialization to use explicit
HttpLinkinstead ofurishorthand
Reviewed changes
Copilot reviewed 39 out of 40 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates Apollo Client package from v3.14.0 to v4.0.11, adds rxjs dependency, removes deprecated dependencies (hoist-non-react-statics, prop-types, react-is@16, rehackt, symbol-observable, ts-invariant, zen-observable) |
| packages/plugin-staking-api/package.json | Updates Apollo Client dependency specification to ^4.0.11 and adds rxjs ^7.8.2 |
| packages/plugin-staking-api/src/types.ts | Introduces QueryReturn type for v4, imports ApolloError from v4-migration package, refactors all Result types to Data types with flattened structure |
| packages/plugin-staking-api/src/Client.ts | Replaces uri shorthand with explicit HttpLink configuration |
| packages/plugin-staking-api/src/index.ts | Updates ApolloProvider import to @apollo/client/react, removes isActiveStaker export |
| packages/plugin-staking-api/src/queries/*.ts | Standardizes query pattern: imports useQuery from @apollo/client/react, adds DEFAULT constants, updates return types to use QueryReturn, uses type parameters in useQuery calls |
| packages/app/src/**/*.tsx | Updates consumer code to destructure new data structure, adjusts null handling patterns |
| packages/global-bus/src/networkConfig/util.ts | Updates type reference from RpcEndpointChainHealth to RpcEndpointHealthData and adjusts property access pattern |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
…loud/polkadot-staking-dashboard into rb/apollo-4-migration
github-project-automation
bot
moved this from ✂️ In progress
to ✅ Done
in Staking Dashboard 2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the codebase from Apollo Client v3 to v4, introducing significant changes to the GraphQL client implementation and query patterns.
Key Changes
@apollo/clientfrom v3.13.9 to v4.0.11 with new peer dependency onrxjsv7.8.2QueryReturn<T>type that guarantees non-null data through default valuesHttpLinkinstead ofurishorthand