feat: add Uniswap V3 Periphery with Hardhat CI harness#286
Conversation
nhussein11
left a comment
There was a problem hiding this comment.
Two things worth a look before merge:
npm installvsnpm ci(tests/docs.test.ts:1796)
The wrapper usesnpm ci, but the harness runsnpm installagainst the upstream project.npm cirespects the lock file and still resolves local file references
(like the@uniswap/v3-corefile:path), so reproducibility would be better. Wasnpm installexplicitly required here, or was it a convenience choice?- Deploy failure silently passes (describe 7)
After exhausting retries, the test catches the error, logs aconsole.warn, and returns — so the Vitest assertion never fails. This means a broken Ignition config
wouldn't block CI either. Consider keeping the soft-fail for genuine testnet unavailability (network errors,IGN403) but re-throwing for anything else, so infra
issues don't go unnoticed.
Adds the polkadot-cookbook test harness for the Uniswap V3 Periphery with EVM on Polkadot Hub tutorial. The harness clones revm-hardhat-examples at pinned commit 96696ad15c3cf01b9168a71ad5114f27c34a8726, installs dependencies (resolving the local @uniswap/v3-core file reference automatically), compiles the SwapRouter and NonfungiblePositionManager contracts, runs the full 39-test Hardhat suite on the local Hardhat network, and optionally deploys via Hardhat Ignition to polkadotTestnet.
79d73fd to
ba5c28e
Compare
|
@nhussein11 |
ok makes sense, please create an issue or jira ticket to address that since in the rest of the tutorials with bruno we are using the pattern I described. Thanks @sekisamu |
Adds the polkadot-cookbook test harness for the Uniswap V3 Periphery with EVM on Polkadot Hub tutorial. The harness clones revm-hardhat-examples at pinned commit 96696ad15c3cf01b9168a71ad5114f27c34a8726, installs dependencies (resolving the local @uniswap/v3-core file reference automatically), compiles the SwapRouter and NonfungiblePositionManager contracts, runs the full 39-test Hardhat suite on the local Hardhat network, and optionally deploys via Hardhat Ignition to polkadotTestnet.
feat(smart-contracts): add uniswap-v3-periphery-hardhat test harness
Companion PR
polkadot-developers/polkadot-docs#1659
Summary
the local Hardhat network, and optionally deploys via Ignition to polkadotTestnet
Why
Companion harness to the existing V3 Core harness — keeps the new Periphery tutorial verified in CI on every push to master.
Test plan
Checklist