-
Notifications
You must be signed in to change notification settings - Fork 78
Fix accounts page #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging/product-ia
Are you sure you want to change the base?
Fix accounts page #1347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the documentation for the accounts page in the Polkadot Hub smart contracts section, focusing on clarifying terminology and expanding guidance on account mapping between Polkadot's 32-byte and Ethereum's 20-byte address formats.
Key changes:
- Updates terminology from "Asset Hub" to "Polkadot Hub" throughout the accounts documentation for consistency
- Adds comprehensive explanations of unmapped Substrate accounts, their limitations, and when mapping is required
- Expands the account mapping section with step-by-step instructions and clearer guidance on the mapping process and its benefits
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| smart-contracts/for-eth-devs/accounts.md | Primary documentation update: terminology changes from "Asset Hub" to "Polkadot Hub", new sections on unmapped account limitations and mapping requirements, enhanced fallback mechanism explanations |
| llms.txt | Updates page title reference in AI training data to reflect new "Polkadot Hub" terminology |
| llms-full.jsonl | Regenerates full AI training dataset with expanded content including new sections on unmapped accounts |
| .ai/site-index.json | Updates site index metadata with new title, preview text, outline structure, and content statistics |
| .ai/pages/smart-contracts-for-eth-devs-accounts.md | Mirrors main documentation changes in AI-optimized format |
| .ai/categories/*.md | Propagates documentation changes across all category aggregation files (tooling, smart-contracts, polkadot-protocol, parachains, networks, infrastructure, dapps, basics) |
Based on my thorough review of this pull request, I found no issues to report. The changes are:
- Technically accurate: The explanations of account mapping, fallback mechanisms, and Keccak-256 hashing are correct
- Well-structured: New sections are logically organized and appropriately placed
- Consistent: Terminology changes are applied consistently throughout the file
- Clear and helpful: The new content provides practical guidance for developers
- Properly formatted: Markdown formatting, links, and syntax are correct
The documentation improvements successfully address the goals stated in the PR description, providing clearer guidance on account mapping requirements and limitations for developers working with Polkadot Hub smart contracts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| 1. **Call the extrinsic**: Use your Substrate wallet to call `pallet_revive.map_account()` | ||
| 2. **Pay the deposit**: A deposit is required and held while the mapping exists (refundable upon unmapping) | ||
| 3. **Receive confirmation**: Once mapped, your account can be used with both Polkadot and Ethereum interfaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not clear to me what happens after you map... do you receive a "mapped" Ethereum address that you have to save or configure in your wallet? Because the whole point is that you want to be able to interact with the ETH RPC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the “controller” of the account will still be the substrate’s original account. The mapped account only serves the purpose of obtaining a mirror account that can receive funds or be used as a destination account. This mapping will not provide the private key or the secret phrase of the new eth account.
Co-authored-by: Erin Shaben <[email protected]>
…ving clarity and consistency in terminology.
📝 Description
This pull request updates the documentation for accounts in Polkadot Hub smart contracts, clarifying the interoperability between Polkadot's 32-byte accounts and Ethereum's 20-byte addresses. The changes improve the explanation of address mapping, explicitly describe the limitations of unmapped accounts, and provide clearer guidance on when and how to map accounts for Ethereum compatibility.
Documentation improvements and clarifications:
🔍 Review Preference
Choose one:
🤖 AI-Ready Docs
If content changed, regenerate AI files:
python3 scripts/generate_llms.py✅ Checklist