split template into 2 opinionated runtimes: AccountId20 + AccountId32#1061
split template into 2 opinionated runtimes: AccountId20 + AccountId32#1061bernardoaraujor wants to merge 12 commits intomasterfrom
Conversation
Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>
Co-authored-by: Qinxuan Chen <koushiro.cqx@gmail.com>
8dccb25 to
f7d72b0
Compare
|
My problem with this approach is that we now have a lot of duplicate code. You may think we can work with them alright, but it actually is a major source of pain whenever the runtime needs changes (which is frequent). Would you mind to implement everything as feature gate instead? We continue to have a single runtime but just optionally built with either account types. I saw you already did it like that for some of the types and client construction code. Also the feature gate |
closing this PR in favor of #1186 |
close #1056