[Template] Zeroing GasLimitPovSizeRatio#1210
Open
arturgontijo wants to merge 2 commits intopolkadot-evm:masterfrom
Open
[Template] Zeroing GasLimitPovSizeRatio#1210arturgontijo wants to merge 2 commits intopolkadot-evm:masterfrom
arturgontijo wants to merge 2 commits intopolkadot-evm:masterfrom
Conversation
Member
|
Please fix the integration tests. |
Collaborator
Author
|
I decided to just remove that test case as we don't have PoV in the template node (also we use non-zero |
koushiro
approved these changes
Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think we need PoV size weight for the
frontier-template-node(solo chain).It is adding
gasUsedto all transactions.