Migrate from self-contained call to new General Extrinsic Format

[vedhavyas]

This PR migrate old Self-Contained Bare extrinsic format to new General Extrinsic format.

Notable changes

• Transaction validation checks are moved to newly defined Extension
• Weight check is removed from pallet-ethereum but it is implicitly checked through Extensions defined.
• Removed self-contained crate as this wont be required anymore

For runtimes that have impl extra logic in their runtime, I have provided a new trait that will be impl by the RuntimeCall

pub trait EthereumTransactionHook<Runtime>
where
	Runtime: Config,
	OriginFor<Runtime>: Into<Result<RawOrigin, OriginFor<Runtime>>>,
{
	fn maybe_ethereum_call(&self) -> Option<&EthereumCall<Runtime>>;

	fn additional_validation(
		&self,
		_signer: H160,
		_source: TransactionSource,
	) -> Result<(), TransactionValidityError> {
		Ok(())
	}
}

additional_validation will be called with signer and the source for any custom validation apart from the common validations pallet-ethereum provides.

[vedhavyas]

Two integration tests are failing

Frontier RPC (Gas limit Weightv2 ref time)
This test should ideally include all the 130 transactions but now it only includes 123
Also noticed, gasUsed is 73117862 which gives a diff of 1882138 remaining gas.

Any suggestions on why remaining 7 txns were not included in the block would be greatly appreciated

I believe the same is the case with Frontier RPC (Gas limit Weightv2 pov size) test as well

update:

If I create a new block, then rest of the transactions are included.
@sorpaas @conr2d if you have any insights I would appreciate to get this going forward

[conr2d]

I'm a bit busy these days, so I'll leave a review soon. However, I don't have merge rights, so my review doesn't guarantee merging this PR.

One immediate comment: fp-self-contained shouldn't be removed at this stage. This removal would break the build for many downstream projets using Frontier. For now, it's better to add a #[deprecated] attribute to fp_self_contained::UncheckedExtrinsic and implement the new approach in the runtime template as you did.

[sorpaas]

Can you pull master?

[vedhavyas]

@sorpaas Missed this.
Unfortunately, i wont be able to finish this at this moment. The PR should be ready post conflicts if anyone is willing to take it from here 🙏🏼