Fix and re-enable some xcm tests #1009
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| /// - Parachain should be able to create a new Foreign Asset at Asset Hub | ||
| #[test] | ||
| fn send_xcm_from_para_to_asset_hub_paying_fee_with_system_asset() { | ||
| pub fn penpal_register_foreign_asset_on_asset_hub(asset_location_on_penpal: Location) { |
There was a problem hiding this comment.
The function penpal_register_foreign_asset_on_asset_hub is nearly identical to the one added in integration-tests/emulated/tests/assets/asset-hub-polkadot/src/tests/send.rs. Consider moving this logic to a shared helper to avoid code duplication.
| let call = AssetHubKusama::create_foreign_asset_call( | ||
| foreign_asset_at_asset_hub.clone(), | ||
| ASSET_MIN_BALANCE, | ||
| para_sovereign_account, |
There was a problem hiding this comment.
The owner and min_balance arguments for create_foreign_asset_call appear to be swapped. ASSET_MIN_BALANCE is being passed as the owner, and para_sovereign_account is passed as the minimum balance. This will lead to a runtime error or incorrect behavior. They should be swapped to match the expected signature (id, owner, min_balance).
| let call = AssetHubPolkadot::create_foreign_asset_call( | ||
| foreign_asset_at_asset_hub.clone(), | ||
| ASSET_MIN_BALANCE, | ||
| para_sovereign_account, |
There was a problem hiding this comment.
The owner and min_balance arguments for create_foreign_asset_call appear to be swapped. ASSET_MIN_BALANCE is being passed as the owner, and para_sovereign_account is passed as the minimum balance. This will lead to a runtime error or incorrect behavior. They should be swapped to match the expected signature (id, owner, min_balance).
3 participants
Fixed some broken and ignored XCM tests.