Skip to content

ci: Test for metadata-hash feature more robustly #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lexnv wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −1
Open

ci: Test for metadata-hash feature more robustly #1041

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fa14ce
ci: Test for metadata-hash in quiet mode
lexnv Dec 18, 2025
4f419ea
ci: Exclude glutton entirely
lexnv Dec 18, 2025
d39805c
ci: Skip all gluttons
lexnv Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,8 @@ jobs:

FEATURES=""
# Find out if the `metadata-hash` feature exists for the given package.
if cargo metadata --format-version=1 | jq '.packages[] | select(.name=="${{ matrix.runtime.package }}") | .features' | grep metadata-hash; then
# Exclude glutton runtimes as they don't support metadata-hash
Copy link
Contributor

@bkchr bkchr Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser, the point of thks if is to filter out packages that don't have the feature. So, we should fix this and not ignoring particular packages. I remember having fixed this at some point, but maybe my memory is not correct.

if [[ "${{ matrix.runtime.package }}" != *"glutton"* ]] && cargo metadata --format-version=1 | jq '.packages[] | select(.name=="${{ matrix.runtime.package }}") | .features' | grep -q metadata-hash; then
FEATURES="metadata-hash"
fi

Expand Down
Loading