Skip to content

Add pallet BlackHole to Kusama AssetHub following WFC #539 #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olanod wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add pallet BlackHole to Kusama AssetHub following WFC #539 #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfb29a3
Add pallet BlackHole to Kusama AssetHub following WFC #539
olanod Jul 5, 2025
9ad5ae6
Add benchmark for pallet dark hole
olanod Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ Changelog for the runtimes governed by the Polkadot Fellowship.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## [Unreleased]

### Added

- Add pallet BlackHole to Kusama AssetHub following [WFC #539](https://kusama.subsquare.io/referenda/539)

## [1.6.1] 24.06.2025

### Changed
Expand Down
28 changes: 20 additions & 8 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ encointer-balances-tx-payment-rpc-runtime-api = { version = "~16.1.0", default-f
encointer-kusama-runtime = { path = "system-parachains/encointer" }
encointer-primitives = { version = "~16.4.0", default-features = false }
enumflags2 = { version = "0.7.7" }
fc-pallet-black-hole = { version = "1.0.0", default-features = false }
frame-benchmarking = { version = "40.2.0", default-features = false }
frame-election-provider-support = { version = "40.1.1", default-features = false }
frame-executive = { version = "40.0.1", default-features = false }
Expand Down
6 changes: 6 additions & 0 deletions system-parachains/asset-hubs/asset-hub-kusama/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ assets-common = { workspace = true }
pallet-xcm-bridge-hub-router = { workspace = true }
snowbridge-inbound-queue-primitives = { workspace = true }

# Frame contrib
fc-pallet-black-hole = { workspace = true }

[dev-dependencies]
asset-test-utils = { workspace = true }
parachains-runtimes-test-utils = { workspace = true }
Expand All @@ -124,6 +127,7 @@ runtime-benchmarks = [
"cumulus-pallet-xcmp-queue/runtime-benchmarks",
"cumulus-primitives-core/runtime-benchmarks",
"cumulus-primitives-utility/runtime-benchmarks",
"fc-pallet-black-hole/runtime-benchmarks",
"frame-benchmarking/runtime-benchmarks",
"frame-support/runtime-benchmarks",
"frame-system-benchmarking/runtime-benchmarks",
Expand Down Expand Up @@ -166,6 +170,7 @@ try-runtime = [
"cumulus-pallet-parachain-system/try-runtime",
"cumulus-pallet-xcm/try-runtime",
"cumulus-pallet-xcmp-queue/try-runtime",
"fc-pallet-black-hole/try-runtime",
"frame-executive/try-runtime",
"frame-support/try-runtime",
"frame-system/try-runtime",
Expand Down Expand Up @@ -212,6 +217,7 @@ std = [
"cumulus-primitives-aura/std",
"cumulus-primitives-core/std",
"cumulus-primitives-utility/std",
"fc-pallet-black-hole/std",
"frame-benchmarking?/std",
"frame-executive/std",
"frame-metadata-hash-extension/std",
Expand Down
21 changes: 21 additions & 0 deletions system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,6 +1061,24 @@ impl pallet_revive::Config for Runtime {
type FindAuthor = <Runtime as pallet_authorship::Config>::FindAuthor;
}

parameter_types! {
pub const BlackHolePalletId: PalletId = PalletId(*b"py/bhole");
pub const AdministrativeBodyId: BodyId = BodyId::Administration;
}

impl fc_pallet_black_hole::Config for Runtime {
type RuntimeEvent = RuntimeEvent;
type WeightInfo = ();
type EventHorizonDispatchOrigin = EitherOfDiverse<
EnsureRoot<AccountId>,
EnsureXcm<IsVoiceOfBody<GovernanceLocation, AdministrativeBodyId>>,
>;
type Balances = Balances;
type BlockNumberProvider = System;
type PalletId = BlackHolePalletId;
type BurnPeriod = ConstU32<DAYS>;
}

// Create the runtime by composing the FRAME pallets that were previously configured.
construct_runtime!(
pub enum Runtime
Expand All @@ -1077,6 +1095,7 @@ construct_runtime!(
TransactionPayment: pallet_transaction_payment = 11,
AssetTxPayment: pallet_asset_conversion_tx_payment = 13,
Vesting: pallet_vesting = 14,
BlackHole: fc_pallet_black_hole = 15,

// Collator support. the order of these 5 are important and shall not change.
Authorship: pallet_authorship = 20,
Expand Down Expand Up @@ -1304,6 +1323,8 @@ mod benches {
// NOTE: Make sure you point to the individual modules below.
[pallet_xcm_benchmarks::fungible, XcmBalances]
[pallet_xcm_benchmarks::generic, XcmGeneric]
// Contrib
[fc_pallet_black_hole, BlackHole]
);

use frame_benchmarking::BenchmarkError;
Expand Down