Skip to content

Conversation

@mutantcornholio
Copy link
Contributor

Upgrading PAPI inside review-bot

Upgrading PAPI inside review-bot
@github-actions
Copy link

Review required! Latest push from author must always be reviewed

@mutantcornholio
Copy link
Contributor Author

mutantcornholio commented Jan 17, 2025

Looks like get-fellows-action also needs attention...

UPD: paritytech/get-fellows-action#37

@bkchr
Copy link
Contributor

bkchr commented Jan 17, 2025

@mutantcornholio it is still failing with the same error as before?

Also this is weird:
image

@mutantcornholio
Copy link
Contributor Author

@mutantcornholio it is still failing with the same error as before?

it still uses 1.1.3, until we merge the PR.
That's because the event in workflow is pull_request_target, not pull_request; this runs workflows from the main branch, not the head branch (which is a good security practice).

Also this is weird:

Appartently, you're not a maintainer in polkadot-fellows, so it requires a maintainer approval for you to run the actions?
Not sure if it'll execute the new version though.
@ggwpez @shawntabrizi could you guys try approving Basti's run, and if that wouldn't do the trick, then maybe merge the PR regardless?

@bkchr
Copy link
Contributor

bkchr commented Jan 20, 2025

Ahh, maybe I was using again the new merge experience...

@bkchr bkchr merged commit a3eae42 into polkadot-fellows:master Jan 20, 2025
1 of 2 checks passed
@mutantcornholio mutantcornholio deleted the patch-1 branch January 21, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants