Skip to content

Przywrócono ikonki roli wizden - #844

Closed
maciejwalendziuk wants to merge 2 commits into
masterfrom
funky-job-icons
Closed

Przywrócono ikonki roli wizden#844
maciejwalendziuk wants to merge 2 commits into
masterfrom
funky-job-icons

Conversation

@maciejwalendziuk

@maciejwalendziuk maciejwalendziuk commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Informacje o PR

Cofnięto zmianę ikonek roli funky.

Powód / Balans

Funky są brzydkie

Szczegóły techniczne

Sprajty

Media

image

Changelog

🆑 haze

  • add: Przeportowano ikonki roli z wizden

@maciejwalendziuk maciejwalendziuk self-assigned this Jul 27, 2026
@github-actions github-actions Bot added S: Niesortowane Status: Element nie został poddany selekcji i nie ma odpowiednich etykiet. S: Wymaga Przeglądu Status: Ten pull request wymaga przeglądu mainteinera size/XS labels Jul 27, 2026
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@maciejwalendziuk, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1150603d-9ea0-4efa-ad31-79be6bef0ddc

📥 Commits

Reviewing files that changed from the base of the PR and between 4c39538 and 0c3ef2d.

⛔ Files ignored due to path filters (98)
  • Resources/Textures/Interface/Misc/job_icons.rsi/Admin.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/AtmosphericTechnician.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Bartender.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Borg.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Botanist.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Boxer.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Brigmedic.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/CBURN.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Captain.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/CargoTechnician.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Chaplain.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Chef.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Chemist.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/ChiefEngineer.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/ChiefMedicalOfficer.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Clown.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Cluwne.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/DeathSquad.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Detective.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/ERTChaplain.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/ERTEngineer.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/ERTJanitor.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/ERTLeader.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/ERTMedical.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/ERTSecurity.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Geneticist.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/HeadOfPersonnel.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/HeadOfSecurity.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/HeadRevolutionary.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/InitialInfected.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Janitor.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Lawyer.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Librarian.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/MedicalDoctor.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/MedicalIntern.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Mime.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/MindShield.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Musician.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Nanotrasen.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/NoId.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/ParadoxClone.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Paramedic.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Passenger.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Pirate.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Prisoner.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Psychologist.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/QuarterMaster.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Reporter.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/ResearchAssistant.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/ResearchDirector.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Revolutionary.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Roboticist.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Scientist.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/SecurityCadet.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/SecurityOfficer.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/SeniorEngineer.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/SeniorOfficer.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/SeniorPhysician.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/SeniorResearcher.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/ServiceWorker.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/ShaftMiner.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/StationAi.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/StationEngineer.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Syndicate.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/TechnicalAssistant.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Unknown.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Virologist.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Visitor.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Warden.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Wizard.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Zombie.png is excluded by !**/*.png
  • Resources/Textures/Interface/Misc/job_icons.rsi/Zookeeper.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/Botanist.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/Captain.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/Chaplain.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/ChiefEngineer.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/ChiefMedicalOfficer.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/Clown.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/ERTChaplain.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/ERTEngineer.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/ERTJanitor.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/ERTLeader.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/ERTMedical.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/ERTSecurity.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/HeadOfSecurity.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/Janitor.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/Lawyer.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/Librarian.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/Mime.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/Musician.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/Paramedic.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/PartyMaker.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/Quartermaster.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/Reporter.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/ResearchDirector.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/SecurityClown.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/ServiceWorker.png is excluded by !**/*.png
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/StationAi.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • Resources/Textures/Interface/Misc/job_icons.rsi/meta.json
  • Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi/meta.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch funky-job-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

RSI Diff Bot; head commit 0c3ef2d merging into 4c39538
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Misc/job_icons.rsi

State Old New Status
Admin Modified
AtmosphericTechnician Modified
Bartender Modified
Borg Modified
Botanist Modified
Boxer Modified
Brigmedic Modified
CBURN Modified
Captain Modified
CargoTechnician Modified
Chaplain Modified
Chef Modified
Chemist Modified
ChiefEngineer Modified
ChiefMedicalOfficer Modified
Clown Modified
Cluwne Modified
DeathSquad Modified
Detective Modified
ERTChaplain Modified
ERTEngineer Modified
ERTJanitor Modified
ERTLeader Modified
ERTMedical Modified
ERTSecurity Modified
Geneticist Modified
HeadOfPersonnel Modified
HeadOfSecurity Modified
HeadRevolutionary Modified
InitialInfected Modified
Janitor Modified
Lawyer Modified
Librarian Modified
MedicalDoctor Modified
MedicalIntern Modified
Mime Modified
MindShield Modified
Musician Modified
Nanotrasen Modified
NoId Modified
ParadoxClone Modified
Paramedic Modified
Passenger Modified
Pirate Modified
Prisoner Modified
Psychologist Modified
QuarterMaster Modified
Reporter Modified
ResearchAssistant Modified
ResearchDirector Modified
Revolutionary Modified
Roboticist Modified
Scientist Modified
SecurityCadet Modified
SecurityOfficer Modified
SeniorEngineer Modified
SeniorOfficer Modified
SeniorPhysician Modified
SeniorResearcher Modified
ServiceWorker Modified
ShaftMiner Modified
StationAi Modified
StationEngineer Modified
Syndicate Modified
TechnicalAssistant Modified
Unknown Modified
Virologist Modified
Visitor Modified
Warden Modified
Wizard Modified
Zombie Modified
Zookeeper Modified

Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi

State Old New Status
Botanist Modified
Captain Modified
Chaplain Modified
ChiefEngineer Modified
ChiefMedicalOfficer Modified
Clown Modified
ERTChaplain Modified
ERTEngineer Modified
ERTJanitor Modified
ERTLeader Modified
ERTMedical Modified
ERTSecurity Modified
HeadOfSecurity Modified
Janitor Modified
Lawyer Modified
Librarian Modified
Mime Modified
Musician Modified
Paramedic Modified
PartyMaker Modified
Quartermaster Modified
Reporter Modified
ResearchDirector Modified
SecurityClown Modified
ServiceWorker Modified
StationAi Modified

Edycja: diff zaktualizowany po 0c3ef2d

@nikitosych

Copy link
Copy Markdown

To nie były wizdenowe, to były funky-station/forky-station#103

@nikitosych nikitosych added S: Pod Znakiem Zapytania Maintainer wyraził obawy dotyczące tego pomysłu. PR może zostać zamknięty przez innego maintainera. P3: Standardowy Priorytet: Domyślny priorytet dla elementów repozytorium. Z4: Bardzo niska Złożoność: Idealne dla początkujących. Łatwo zrozumieć, jak dojść do wyznaczonego celu. and removed S: Wymaga Przeglądu Status: Ten pull request wymaga przeglądu mainteinera S: Niesortowane Status: Element nie został poddany selekcji i nie ma odpowiednich etykiet. labels Jul 28, 2026
@maciejwalendziuk

Copy link
Copy Markdown
Collaborator Author

O boże serio?? Fuj!!

@maciejwalendziuk maciejwalendziuk changed the title Ikonki roli funky Przywrócono ikonki roli wizden Jul 28, 2026
@nikitosych

Copy link
Copy Markdown

ale sam zdecydowałeś że są fuj? imo są dobre

@maciejwalendziuk

Copy link
Copy Markdown
Collaborator Author

tak, to moja opinia: "ikonki roli funky sa fuj"

@maciejwalendziuk

Copy link
Copy Markdown
Collaborator Author

a jesli pytasz czy otworzylem PR bo "nie podobaja mi sie ikonki" to tylko dodam, ze ikonki funky wywolaly spore poruszenie spolecznosci. decyzje czy mergujemy zostawiam wam

@Froozigiusz

Copy link
Copy Markdown

a jesli pytasz czy otworzylem PR bo "nie podobaja mi sie ikonki" to tylko dodam, ze ikonki funky wywolaly spore poruszenie spolecznosci. decyzje czy mergujemy zostawiam wam

Patrząc na oryginalną zmianę wspomnianą wcześniej, coś nie widzę by to była kontrowersyjna zmiana. Spora? Może i tak, “Wizard's Den”–a inicjatywa zwiększenia jakości grafik również odbił się sporym echem; tutaj jednak tego nie ma.

@Zintex

Zintex commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Jak dla mnie, to tylko nadzorca i komendant wymagają zmiany. Nadzorca oko jak miał wcześniej, komendant albo to co miał wcześniej albo jeszcze inna ikonka.
Obecne oko za komendanta łamie prawidłowość, że niebieski to dowodzenie. Oraz to była wcześniej ikona nadzorcy powoduje zamęt (myli się, że obecny komendant jest nadzorcą). A obecny nadzorca jako więzień, ale czerwony jest zbyt podobny do więźnia, przez co można pomylić oraz jest kwestia "accessibility". Symbole powinny być rozróżnialne dla osób nieodróżniających kolory. Obecny warden i więzień nie są. Różniące się nowe ikony headów są na plus z accessibility. No tylko jak wspominałem, popsuta rozróżnialność wardena-więźnia oraz użycie czerwonego oczka co było wardenem do hosa co jest mylące i niekonsekwentne.

@maciejwalendziuk
maciejwalendziuk marked this pull request as draft July 30, 2026 13:20
@nikitosych nikitosych closed this Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3: Standardowy Priorytet: Domyślny priorytet dla elementów repozytorium. S: Pod Znakiem Zapytania Maintainer wyraził obawy dotyczące tego pomysłu. PR może zostać zamknięty przez innego maintainera. size/XS Z4: Bardzo niska Złożoność: Idealne dla początkujących. Łatwo zrozumieć, jak dojść do wyznaczonego celu. Zmiany: Brak C# Zmiany: Sprite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants