Skip to content

Mark our attribute as [Embedded]#21

Draft
tautropfli wants to merge 11 commits into
mainfrom
embedded
Draft

Mark our attribute as [Embedded]#21
tautropfli wants to merge 11 commits into
mainfrom
embedded

Conversation

@tautropfli

Copy link
Copy Markdown
Member

Depends on #20

Marking the [DiscriminatedUnion] attribute with [Embedded] avoids
compiler warnings when using InternalsVisibleTo.

I discovered this today while browsing through the Incremental Generators Cookbook.

@tautropfli tautropfli changed the title Embedded Mark our attribute as [Embedded] Jan 21, 2025

@tautropfli tautropfli left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on #20

@tautropfli

Copy link
Copy Markdown
Member Author

Converting back to draft as this may sometimes produce an error.
See https://github.com/dotnet/roslyn/blob/main/docs/compilers/CSharp/Compiler%20Breaking%20Changes%20-%20DotNet%2010.md

@tautropfli tautropfli marked this pull request as draft January 21, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant