Skip to content

Conversation

@bash
Copy link
Member

@bash bash commented Jan 21, 2025

Depends on #20

Marking the [DiscriminatedUnion] attribute with [Embedded] avoids
compiler warnings when using InternalsVisibleTo.

I discovered this today while browsing through the Incremental Generators Cookbook.

@bash bash requested review from FreeApophis and Mafii January 21, 2025 14:12
@bash bash changed the title Embedded Mark our attribute as [Embedded] Jan 21, 2025
Copy link
Member Author

@bash bash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on #20

@bash
Copy link
Member Author

bash commented Jan 21, 2025

Converting back to draft as this may sometimes produce an error.
See https://github.com/dotnet/roslyn/blob/main/docs/compilers/CSharp/Compiler%20Breaking%20Changes%20-%20DotNet%2010.md

@bash bash marked this pull request as draft January 21, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant