Skip to content

Conversation

@bash
Copy link
Member

@bash bash commented Jan 29, 2025

Resolves #824

@bash bash requested a review from FreeApophis January 29, 2025 17:46
@bash bash enabled auto-merge January 29, 2025 17:47
FreeApophis
FreeApophis previously approved these changes Jan 30, 2025
@bash
Copy link
Member Author

bash commented Jan 30, 2025

sigh I finally figured it out: The audit warnings only appear when restoring with the linux-x64 runtime because then System.Private.Uri gets pulled in transitively. To reproduce it locally one has to also enable auditing of transitive dependencies using /p:NugetAuditMode=all (which is enabled by default on CI apparently).

Full command to reproduce: dotnet restore -r linux-x64 /p:NugetAuditMode=all Funcky.TrimmingTest.

@bash bash requested a review from FreeApophis January 30, 2025 09:43
@FreeApophis
Copy link
Member

FreeApophis commented Jan 30, 2025

Visual Studio's Package Manager also checks the transitive dependencies since the new Visual Studio release.

@bash bash merged commit 62e101a into main Jan 30, 2025
9 checks passed
@bash bash deleted the audit-warnings branch January 30, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning NU1904 cluttering the Build in Visual Studio

2 participants