Fix some rough edges of Roslyn multi-targeting #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bash
force-pushed
the
fix-analyzers
branch
3 times, most recently
from
7880c3a to
3b10ef5
Compare
This fixes the incorrect resource name for Funcky.Analyzers.Roslyn4.0 (which is implicitly derived from the RootNamespace which in turn is implicitly derived from the project file name).
FreeApophis
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #834
I learned some new things while testing the analyzer package with both an SDK that supports multi-targeting and one that doesn't:
RootNamespaceproperty which in turn is derived from the project name, not theAssemblyNameas I had previously thought. This means that the resources could not be loaded for one of the analyzer versions :/roslyn*directory. Luckily the minimum Roslyn version that we support (4.0) was shipped with an SDK that already supports multi-targeting, so now we now put that analyzer version insideroslyn4.0.roslyn*directories) which causes lots of noisy errors. To improve the situation in that case, I have included a.targetsfile that removes the analyzers and warns the user.