Always run public API analyzers on newest target framework #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mafii
reviewed
Feb 11, 2025
Mafii
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intentionally run the public API analyzers only on the newest target framework because we usually add APIs in newer target frameworks that are missing in older ones.
I have sometimes forgotten to update the target framework condition (for instance in Funcky.Async). To prevent this I introduced a property
FunckyNewestTargetFrameworkthat sits right next to the other target frameworks so that they (hopefully) get bumped together.We also get a warning now if we don't set the property altogether.