Skip to content

Conversation

@csillikd-messerli
Copy link
Contributor

I deliberately chose Flatten; I find Join less self-explanatory.

@bash
Copy link
Member

bash commented Jun 2, 2025

I haven't really had a need for Flatten, but I also don't have any strong preference against it. Maybe @FreeApophis or @Mafii have a preference for/against this?

One thing to note is that for WhereSelect we chose to go with an overload for flattening:
#448 I'm not sure if SelectMany() is very clear though, so Flatten is probably the better choice?

bash
bash previously requested changes Jun 2, 2025
Copy link
Member

@bash bash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm otherwise

@FreeApophis
Copy link
Member

I think Flatten is good choice as a name, but I think we want to rename WhereSelect too in that case.

@bash bash dismissed their stale review July 28, 2025 09:23

review addressed

@csillikd-messerli csillikd-messerli merged commit a1f80fd into main Jul 28, 2025
9 checks passed
@csillikd-messerli csillikd-messerli deleted the add-flatten branch July 28, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants