Skip to content

fix: replace bare except with except Exception in mpltools.py#28

Open
harshadkhetpal wants to merge 1 commit into
polyaxon:masterfrom
harshadkhetpal:fix/bare-except-mpltools
Open

fix: replace bare except with except Exception in mpltools.py#28
harshadkhetpal wants to merge 1 commit into
polyaxon:masterfrom
harshadkhetpal:fix/bare-except-mpltools

Conversation

@harshadkhetpal

Copy link
Copy Markdown

Summary

Replace bare except: clauses with except Exception: in mpltools.py (2 occurrences).

Bare except: catches all exceptions including SystemExit, KeyboardInterrupt, and GeneratorExit, which is almost never intended. Using except Exception: follows PEP 8 best practices.

Changes:

# Before (mpltools.py:555, 564)
except:
    return _dates

# After
except Exception:
    return _dates

Testing

No behavior change for normal exceptions — style/correctness fix only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant