forked from secdev/scapy
-
Notifications
You must be signed in to change notification settings - Fork 3
Add single layer UDS configuration mode #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ff9a9a4
Add single_layer_UDS config option to UDS contrib
Copilot f28bd73
Address code review: explicit length check and closure comment
Copilot e9467d8
Add single layer UDS config, tests, and documentation
Copilot 4354e39
Fix uds_single_layer_mode idempotency and clarify test naming
Copilot db73b4a
Make service decorator and single layer mode generic for KWP, OBD, GMLAN
Copilot 7ea604d
Fix flake8 and mypy issues introduced by generic service decorator ch…
Copilot a7517ff
Fix remaining flake8 and mypy issues in automotive protocol files
Copilot 0b07906
Remove _make_single_layer_mode helper; rename config key to single_la…
Copilot 58162cf
Update documentation to reflect single_layer_mode rename and removal …
Copilot 3fc4bd5
Remove _make_service_decorator; add ConditionalField explicitly in ev…
Copilot a8f05e9
Make OBD service ConditionalField modifications explicit per-class in…
Copilot c137bec
Address PR review: delete utils.py, fix type annotations, named slm f…
Copilot 45e6653
feat: add compatibility_mode flag to UDS, KWP, GMLAN, OBD single-laye…
Copilot 242ab0d
fix: use Packet type annotation in _kwp_slm; simplify OBD assertion i…
Copilot ea02c8f
fix: use valid 7-byte test data for GMLAN_RFRDPR sub-subpacket test i…
Copilot b8ed598
fix: resolve flake8 E302/E501/F401 errors in changed automotive files
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simplify this table or remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified in c137bec — replaced the per-protocol table with a single-line note: "The same
single_layer_modekey works for all protocols: replace'UDS'with'KWP','OBD', or'GMLAN'as appropriate." Also removed the bullet-point explanation and the reference to the deletedautomotive.utilsmodule.