[runtime]: Uncle proofs in pallet-beefy-consensus-proofs#802
Open
[runtime]: Uncle proofs in pallet-beefy-consensus-proofs#802
Conversation
seunlanlege
reviewed
Apr 28, 2026
Member
|
I think its a good idea to have some simnode tests with naive beefy to validate this behaviour |
seunlanlege
reviewed
Apr 29, 2026
Member
|
Looking good, 2 things
|
seunlanlege
approved these changes
Apr 30, 2026
Wizdave97
reviewed
Apr 30, 2026
seunlanlege
changed the title
Member
|
So essentially anyone can copy a proof, add some byte padding and it would still succeed? @dharjeezy we need to prevent this actually. Either by ensuring decoding consumes all bytes, or re-encoding to abi before hashing to ensure proof uniqueness |
…-trip, and reject set_reward_curve entries where numerator > denominator.
seunlanlege
reviewed
May 1, 2026
| abi_payload, | ||
| ) | ||
| .map_err(|_| Error::<T>::AbiDecodeFailed)?; | ||
| if <ismp_solidity_abi::sp1_beefy::SP1Beefy::SP1BeefyProof as SolType>::abi_encode_params(&p) |
Member
There was a problem hiding this comment.
better to use the abi encoding to compute the proof hash instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds uncle proofs so multiple independent
SP1provers can race for the same target and all get paid, with a decreasing reward curve so the fastest still wins the largest share. Naive proofs are testnet-only with zero reward, so uncles apply toSP1only.submit_proofis now a signed extrinsic. The signer is the reward payee. Successful proofs returnPays::No(fee refunded along with the reward); failed proofs pay the fee, which is the spam deterrent. The oldValidateUnsignedpath with hand-rolledSR25519signing is gone.closes #798