dynamic extensions: improve build rules for internal api deps, disable fission#226
Open
dynamic extensions: improve build rules for internal api deps, disable fission#226
Conversation
kralicky
force-pushed
the
kralicky/dynamic-extension-api-deps
branch
from
aedfbf5 to
04002df
Compare
Coverage Report for CI Build 25124307548Coverage remained the same at 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes extensions which need to include protobuf packages built via the envoy api build system that are not present in the host binary. Additionally, fission is now disabled for extensions, since it is not possible to build dwp packages for them due to some bazel limitations wrt propagating debug context in CcInfo (and debug context being an internal api for some reason). Extensions are small enough anyway where the extra few MB of debug info is inconsequential.