ssh: add api definitions #7
Conversation
kralicky
force-pushed
the
kralicky/ssh-api-definitions
branch
from
f9731c8 to
fcaed2e
Compare
api/extensions/filters/network/ssh/filters/session_recording/raw_format.proto
Outdated
Show resolved
Hide resolved
api/extensions/filters/network/ssh/filters/session_recording/raw_format.proto
Show resolved
Hide resolved
api/extensions/filters/network/ssh/filters/session_recording/session_recording.proto
Show resolved
Hide resolved
api/extensions/filters/network/ssh/filters/session_recording/session_recording.proto
Show resolved
Hide resolved
| } | ||
|
|
||
| message RecordingData { | ||
| oneof data { |
There was a problem hiding this comment.
Would this be a good place for a few comments about the expected order of these data chunks?
Is it basically:
- 1 chunk with the
metadata - n chunks of the stream recording contents
- 1 final chunk with the
checksum?
|
|
||
| option go_package = "github.com/pomerium/envoy-custom/api/extensions/filters/network/ssh"; | ||
|
|
||
| message Config {} |
There was a problem hiding this comment.
Is this empty message required by the Generic Proxy architecture? If so it might be nice to add a comment mentioning that here.
There was a problem hiding this comment.
This was an old unused message, will remove it
| // temporarily becomes the upstream server, and delays the connection to the real upstream | ||
| // until this stream is closed. Afterwards, Envoy connects to the real upstream server and | ||
| // "hands off" the stream internally in a way that is transparent to the downstream. | ||
| rpc ServeChannel(stream ChannelMessage) returns (stream ChannelMessage); |
There was a problem hiding this comment.
In the interest of splitting things up into small chunks, should we hold off on adding this RPC and its associated messages for now?
There was a problem hiding this comment.
No, I would prefer to keep this here for now
| @@ -2,6 +2,6 @@ syntax = "proto3"; | |||
|
|
|||
| package pomerium.extensions; | |||
|
|
|||
| option go_package = "github.com/pomerium/envoy-custom/source/extensions/http/early_header_mutation/trace_context"; | |||
| option go_package = "github.com/pomerium/envoy-custom/api/extensions/http/early_header_mutation/trace_context"; | |||
There was a problem hiding this comment.
Definitely good to be consistent in the import path we use for these protos, but should this go in a separate PR?
| } | ||
|
|
||
| enum PacketDirection { | ||
| NONE = 0; |
There was a problem hiding this comment.
Which packets do not have a direction? (Or should this be the standard UNKNOWN enum value?)
There was a problem hiding this comment.
I think I was going to use this for something, but didn't end up needing it.
There was a problem hiding this comment.
Would it be worth adding an UNKNOWN anyway, just in case we need to extend this enum later?
kralicky
force-pushed
the
kralicky/ssh-api-definitions
branch
from
edc6033 to
fbbbe6e
Compare
kralicky
force-pushed
the
kralicky/ssh-api-definitions
branch
from
fbbbe6e to
e4f16ca
Compare
No description provided.