add support for k8s leader election#1386
Merged
kenjenkins merged 2 commits intomainfrom Apr 30, 2026
Merged
Conversation
In principle, when ingress-controller runs in the standalone mode and uses the new unified API sync, it does not need a direct connection to the Core databroker. However, ingress-controller does currently rely on Core for leader election. Add support to instead use Kubernetes leader election in this case. Bypass the databroker lease and disable the corresponding readyz check. Refactor the kustomize configuration so that we can add permissions for acquiring a k8s lease object only within the 'pomerium' namespace.
kenjenkins
force-pushed
the
kenjenkins/sync-api-standalone
branch
from
e7f0102 to
4795120
Compare
calebdoxsey
approved these changes
Apr 27, 2026
wasaga
reviewed
Apr 28, 2026
wasaga
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In principle, when ingress-controller runs in the standalone mode and uses the new unified API sync, it does not need a direct connection to the Core databroker. However, ingress-controller does currently rely on Core for leader election.
Add support to instead use Kubernetes leader election in this case. Rename the
acquire-databroker-leasehealth check to justacquire-leaseto reflect that the lease being acquired is not necessarily a databroker lease. Refactor the kustomize configuration so that we can add permissions for acquiring a k8s lease object only within the 'pomerium' namespace.Related issues
https://linear.app/pomerium/issue/ENG-3959/ingress-controller-allow-standalone-mode-independent-of-core
Checklist
improvement/bug/ etc)