fix: timeout error no longer appears after tool call fail or new chat#131
Merged
fix: timeout error no longer appears after tool call fail or new chat#131
Conversation
Added a test case to verify that the streamText function emits a stream_done event even when an error occurs during streaming. This ensures consistent behavior in error scenarios. Updated the implementation to always enqueue the stream_done chunk after an error is encountered.
✅ Deploy Preview for mcp-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the chat functionality and streaming logic to improve error handling and streamline event signaling. The most important changes include adding a reset for the
timedOutstate in the chat component, centralizing thestream_doneevent chunk, and ensuring thestream_doneevent is emitted even when errors occur during streaming.Relates to #127