Skip to content

fix: server & tools selected count takes tools into account now#137

Merged
wasaga merged 3 commits intomainfrom
tool-server-count-fix
Jul 12, 2025
Merged

fix: server & tools selected count takes tools into account now#137
wasaga merged 3 commits intomainfrom
tool-server-count-fix

Conversation

@nickytonline
Copy link
Copy Markdown
Member

@nickytonline nickytonline commented Jul 11, 2025

Now the tools selected appear in the total count for selected servers and selected tools.

Closes #132

Before

CleanShot 2025-07-11 at 18 28 12

After

CleanShot 2025-07-11 at 18 26 54

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 11, 2025

Deploy Preview for mcp-storybook ready!

Name Link
🔨 Latest commit 6e935d5
🔍 Latest deploy log https://app.netlify.com/projects/mcp-storybook/deploys/68728086599c1f00085a270c
😎 Deploy Preview https://deploy-preview-137--mcp-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nickytonline nickytonline requested review from wasaga and zeucapua July 11, 2025 22:29
@nickytonline nickytonline marked this pull request as draft July 11, 2025 22:40
@nickytonline nickytonline force-pushed the tool-server-count-fix branch from d8b4a12 to 5c46bc1 Compare July 12, 2025 13:09
@nickytonline nickytonline changed the title fix: add selected tools count to ServerSelector fix: server & tools selected count takes tools into account now Jul 12, 2025
@nickytonline nickytonline marked this pull request as ready for review July 12, 2025 13:09
expect(consoleErrorSpy).toHaveBeenCalledWith(
'Failed to fetch servers:',
expect.objectContaining({ message: 'Network down' })
expect.objectContaining({ message: 'Network down' }),
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes here and above a re just Prettier formatting things.

@nickytonline nickytonline marked this pull request as draft July 12, 2025 14:43
@nickytonline nickytonline marked this pull request as ready for review July 12, 2025 15:21
@nickytonline nickytonline force-pushed the tool-server-count-fix branch from f057433 to 54819c4 Compare July 12, 2025 15:21
@nickytonline nickytonline marked this pull request as draft July 12, 2025 15:26
@nickytonline nickytonline force-pushed the tool-server-count-fix branch from 54819c4 to 6e935d5 Compare July 12, 2025 15:34
@nickytonline nickytonline marked this pull request as ready for review July 12, 2025 15:34
@wasaga wasaga merged commit 4a88086 into main Jul 12, 2025
6 checks passed
@wasaga wasaga deleted the tool-server-count-fix branch July 12, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile Server and Tools button doesn't display correct number of tools and servers

2 participants