Skip to content

ci: add github actions#40

Merged
wasaga merged 5 commits intomainfrom
wasaga/docker-hub
Jun 2, 2025
Merged

ci: add github actions#40
wasaga merged 5 commits intomainfrom
wasaga/docker-hub

Conversation

@wasaga
Copy link
Copy Markdown
Collaborator

@wasaga wasaga commented Jun 2, 2025

GitHub

  1. issue types
  2. build docker for PR branch
  3. build and publish main to docker hub

Copilot AI review requested due to automatic review settings June 2, 2025 21:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces initial CI workflows for Docker image builds and adds GitHub issue templates.

  • Adds a pull-request workflow to build (but not push) Docker images
  • Adds a push-to-main workflow to build and publish multi-arch Docker images
  • Adds templates for feature requests and bug reports

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/test.yaml New workflow: builds Docker image on PR branches
.github/workflows/docker-main.yaml New workflow: builds & pushes Docker on main
.github/ISSUE_TEMPLATE/feature_request.md New feature request issue template
.github/ISSUE_TEMPLATE/bug.md New bug report issue template
Comments suppressed due to low confidence (3)

.github/workflows/test.yaml:1

  • [nitpick] The workflow name "Docker Main" is identical in both CI files; consider renaming this PR workflow to something like "Docker PR" for clarity.
name: Docker Main

.github/workflows/docker-main.yaml:20

  • You're building for linux/arm64 but haven't enabled QEMU under this job; add a docker/setup-qemu-action step before Buildx to support cross-architecture builds.
-      - name: Set up Docker Buildx

.github/ISSUE_TEMPLATE/feature_request.md:2

  • [nitpick] The template filename feature_request.md uses an underscore but bug.md does not; consider a consistent naming convention like bug_report.md and feature_request.md or bug.md and feature.md.
name: Feature request

context: .
file: ./Dockerfile
push: false
platforms: linux/amd64
Copy link

Copilot AI Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR build only targets linux/amd64; consider adding linux/arm64 here to catch ARM build issues early.

Suggested change
platforms: linux/amd64
platforms: linux/amd64,linux/arm64

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we run into issues in the future, linux/amd64,linux/amd64/v2,linux/arm64 are the currently possible platforms in gcp.

Comment thread .github/workflows/test.yaml Outdated
Comment thread .github/ISSUE_TEMPLATE/bug.md Outdated
wasaga and others added 3 commits June 2, 2025 17:24
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@wasaga wasaga merged commit 83e1d7c into main Jun 2, 2025
1 check passed
@wasaga wasaga deleted the wasaga/docker-hub branch June 2, 2025 21:48
nickytonline pushed a commit that referenced this pull request Jun 11, 2025
GitHub 

1. issue types
2. build docker for PR branch
3. build and publish main to docker hub

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants